-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Memory leak in repo-server #20876
Merged
crenshaw-dev
merged 1 commit into
argoproj:master
from
AJChandler:repo_server_mem_leak_cmp_discovery
Nov 21, 2024
Merged
fix: Memory leak in repo-server #20876
crenshaw-dev
merged 1 commit into
argoproj:master
from
AJChandler:repo_server_mem_leak_cmp_discovery
Nov 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Chandler <adam_chandler@trimble.com>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20876 +/- ##
==========================================
+ Coverage 55.00% 55.04% +0.04%
==========================================
Files 324 324
Lines 55398 55400 +2
==========================================
+ Hits 30471 30497 +26
+ Misses 22309 22279 -30
- Partials 2618 2624 +6 ☔ View full report in Codecov by Sentry. |
crenshaw-dev
approved these changes
Nov 21, 2024
/cherry-pick release-2.13 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Nov 21, 2024
Signed-off-by: Adam Chandler <adam_chandler@trimble.com>
crenshaw-dev
pushed a commit
that referenced
this pull request
Nov 21, 2024
adriananeci
pushed a commit
to adriananeci/argo-cd
that referenced
this pull request
Dec 4, 2024
Signed-off-by: Adam Chandler <adam_chandler@trimble.com> Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves a memory leak in the repo-server during plugin discovery caused by the connection not being closed.
Repo-Server Goroutines Leak
Repo-Server Goroutines Leak - Hard Refresh Applications x2
Fix Applied - Repo-Server Goroutines Leak - Hard Refresh Applications x2
Introduced by: #20196
Related improvement that would make this class of error harder to occur: #20217
This should be cherry-picked into the v2.13 release.
Checklist: